> On May 19, 2014, 1:06 p.m., Marco Martin wrote: > > looks fine. > > can you try it also on an item that uses dbusmenu for menus, like kmix?
I just tried kmix and it looks fine to me on both left and right click. Both menus behave like I would expect (override redirect, grabbing pointer/keyboard). - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58139 ----------------------------------------------------------- On May 19, 2014, 12:56 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118200/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 12:56 p.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: knotifications > > > Description > ------- > > [StatusNotifier] Don't set custom window flags on ContextMenu > > A QMenu has proper default flags with BypassWindowManagerHint. > Thus all the setting of hints and force activate is not needed. > Also it takes care of grabbing keyboard and pointer in this case > resulting in the popup being closed when clicked outside. > > This fixes interaction problems with Klipper. > > > Diffs > ----- > > src/kstatusnotifieritemdbus_p.cpp 0073afacfc3c0a5b6164e0e777471e1d5ea3cb43 > > Diff: https://git.reviewboard.kde.org/r/118200/diff/ > > > Testing > ------- > > Klipper properly grabs the pointer and clicking outside Klipper's context > menu, ends it. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
