----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118195/#review58167 -----------------------------------------------------------
This review has been submitted with commit 17977dcd85442a4cf8f59593ab486ba813cbd0df by Alex Merry to branch master. - Commit Hook On May 19, 2014, 2:39 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118195/ > ----------------------------------------------------------- > > (Updated May 19, 2014, 2:39 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kded > > > Description > ------- > > Look for kded modules without kded_ prefix first > > The implicit kded_ prefix is weird, and contrary to what most other > kservice-based things do. It also means that kded modules cannot > (easily) be placed in a subdirectory of the plugin directory. > > The old-style naming is still supported, for compatibility. > > > Diffs > ----- > > src/kded.cpp 6a3c4935b81ad42324eddc756b24ca85450b8e83 > > Diff: https://git.reviewboard.kde.org/r/118195/diff/ > > > Testing > ------- > > Built, installed. Ran kded5, and made sure > `qdbus org.kde.kded5 /modules/kcookiejar` > still worked (loaded the module etc) with the old-style naming. > > Performed the same test after removing the old kded_kcookiejar.so, and > installing a modified desktop file with the library set to > kf5/kded/kcookiejar, and the kcookiejar module installed as > PLUGIN_DIR/kf5/kded/kcookiejar.so (and restarting kded5, of course). > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel