> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275630#file275630line77> > > > > for new connects I would use the new compile time checked syntax.
I tried it but it was giving some error "unable to deduce function pointer <FUNC1>" > On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/xinput_helper.cpp, line 95 > > <https://git.reviewboard.kde.org/r/118366/diff/2/?file=275639#file275639line95> > > > > removing the event doesn't remove the fact that this method is not yet > > ported. See the #if 0 which indicates that this code has not been adjusted > > to xcb yet. Will be porting it later ! - shivam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review58618 ----------------------------------------------------------- On May 29, 2014, 7:53 a.m., shivam makkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118366/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 7:53 a.m.) > > > Review request for kde-workspace, KDE Frameworks and Andriy Rysin. > > > Repository: plasma-desktop > > > Description > ------- > > Removed deprecated statements and ported keyboard module to framework 5. > > > Diffs > ----- > > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/bindings.cpp 21541e0 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp b768586 > kcms/keyboard/flags.cpp 6d25443 > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard.ui 0062d1c > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcm_keyboard_widget.cpp 21685eb > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.h 411bdd2 > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp 6f787ea > kcms/keyboard/kcmmisc.cpp d14ac2e > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/kcmmiscwidget.ui 37fbaf4 > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp f3ff97c > kcms/keyboard/keyboard_config.cpp 49f059c > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_daemon.cpp 25673b0 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/keyboard_hardware.cpp dca49b6 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory.cpp 9e72361 > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layout_memory_persister.cpp 8a6118a > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp fd436c4 > kcms/keyboard/layouts_menu.cpp e357c6a > kcms/keyboard/x11_helper.h 719b13f > kcms/keyboard/x11_helper.cpp 0e2806e > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.h 343d7ed > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b311579 > kcms/keyboard/xinput_helper.cpp b245e91 > > Diff: https://git.reviewboard.kde.org/r/118366/diff/ > > > Testing > ------- > > > Thanks, > > shivam makkar > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel