----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118128/#review58752 -----------------------------------------------------------
hehehe, that's quite a change. This will keep sorting happy. I think this is the way to go and let the GUI format the number how it wants to display it. +1 from me. - Mark Gaiser On May 29, 2014, 5 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118128/ > ----------------------------------------------------------- > > (Updated May 29, 2014, 5 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kio > > > Description > ------- > > Now I'm not sure if returning the unit together with the size won't break > some things, but as it returns string already, I thought returning it in the > "human readable" form would be better than always returning bytes. > > > Diffs > ----- > > src/widgets/kdirmodel.cpp 70d5ee4 > > Diff: https://git.reviewboard.kde.org/r/118128/diff/ > > > Testing > ------- > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
