> On June 2, 2014, 4:35 p.m., David Faure wrote: > > Well spotted. > > > > Porting bug (from time_t to QDateTime) in b4d30c9fab4c.
I see that it was done also in cacheParseResponseHeader and resetSessionSettings should be probably fixed there too? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/#review58997 ----------------------------------------------------------- On June 2, 2014, 4:41 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118473/ > ----------------------------------------------------------- > > (Updated June 2, 2014, 4:41 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > In relation to https://bugs.kde.org/show_bug.cgi?id=334767 > seems that kio::file_copy calls fail because a wrong If-Modified-Since: is > sent in the request header and the answer is almost always 304 not modified. > > I compared the http kioslave with the kde4 version, and i seen that it used > to reset m_request.cacheTag.servedDate > m_request.cacheTag.lastModifiedDate and m_request.cacheTag.expireDate in > HTTPProtocol::sendQuery() > > This has been removed in the Kf5 port, but if i restore it, KIO::file_copy > seems to work correctly again > > > Diffs > ----- > > src/ioslaves/http/http.cpp c81ad41 > > Diff: https://git.reviewboard.kde.org/r/118473/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
