> On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/core/kconfiggroup.cpp, line 205 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280266#file280266line205> > > > > shouldn't this be translated?
It's an error string, should it? > On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/kconf_update/kconf_update.cpp, line 209 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280274#file280274line209> > > > > Why do you change Q_FOREACH to foreach? I originally changed them to range-based for, but then remembered we can't use it. I'll change them back. > On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/kconf_update/kconfigutils.cpp, line 36 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280275#file280275line36> > > > > This modifies the actual semantic of the function, although it might > > still be correct. It was making an unnecessary copy of the list. > On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/kconf_update/kconfigutils.cpp, line 38 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280275#file280275line38> > > > > "" -> QString() It uses a QByteArray internally, so no conversion necessary. > On June 11, 2014, 2:44 p.m., Aleix Pol Gonzalez wrote: > > src/kconf_update/kconf_update.cpp, line 275 > > <https://git.reviewboard.kde.org/r/118666/diff/1/?file=280274#file280274line275> > > > > Doesn't that make the KConfig go out of scope too early? > > Yes it does, what was I thinking? I'll fix. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118666/#review59803 ----------------------------------------------------------- On June 11, 2014, 1:59 p.m., Thomas Braxton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118666/ > ----------------------------------------------------------- > > (Updated June 11, 2014, 1:59 p.m.) > > > Review request for KDE Frameworks and Matthew Dawson. > > > Repository: kconfig > > > Description > ------- > > Simple Cleanups > - use Q_NULLPTR instead of 0 or NULL > - simplify some foreach loops > - use QStringLiteral in a few places > - added a few consts > > > Diffs > ----- > > autotests/kconfigloadertest.cpp 451d636e4e584a97d897634b1db1459b47e12355 > src/core/kconfig.h d27eebe7c41cb433b1808882c53cbf7b4c870950 > src/core/kconfig.cpp ea9746c001e235529a1cdd5865b9e1b5c129b56a > src/core/kconfigbackend.cpp 90655facb49ebb1702fa1635ae5db3fc11fc31a3 > src/core/kconfigdata.h e57becb24936865d009a700892893049b3e079f1 > src/core/kconfiggroup.h 3c4bce8433e3c5d4cb2d9fdd111a43f04cf3c295 > src/core/kconfiggroup.cpp 6f609baefec5beaf38fdfedd6d192b395e3f8acb > src/core/kconfigini.cpp df834f57fc44bbf9f4f28f1bc4eb5717e2ff1cee > src/core/kcoreconfigskeleton.h bb9c1cf936b87e2456726a2bb3428be42558b39f > src/gui/kconfiggroupgui.cpp a14c204c143b38189f042c37ccbe1bf6355a2a18 > src/gui/kconfiggui.cpp 1eee8ce50fd660f11cad53c2a493072317e1f331 > src/gui/kconfigloader.h 36eb182fbf1c241a043566a13d7c6c123a6e455f > src/gui/kconfigloader.cpp 1dd9e7fc44a367165fedc2e7760c8b524ecd210e > src/gui/kconfigskeleton.h f87eef6e5268a3b4e93fd733f70a2bdd4c4be753 > src/kconf_update/kconf_update.cpp 829d35e61da3d303539044d0dc652cc99dec35a2 > src/kconf_update/kconfigutils.cpp f2663e1316ec2cdbef303385787d14406e02f4a1 > > Diff: https://git.reviewboard.kde.org/r/118666/diff/ > > > Testing > ------- > > All tests still pass > > > Thanks, > > Thomas Braxton > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
