----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/ -----------------------------------------------------------
(Updated June 29, 2014, 1:49 p.m.) Review request for KDE Frameworks and Matthew Dawson. Changes ------- Update after feedback. With mainConfig in the threadstorage, I removed the isMainThread check for the test-mode check after all, it just looked wrong to be restrictive there. Summary (updated) ----------------- KSharedConfig: move mainConfig and wasTestEnabled to the thread storage. Repository: kconfig Description (updated) ------- KSharedConfig: move mainConfig and wasTestEnabled to the thread storage. This enables the mainConfig optimization in all threads, and ensures the user warning only happens in the main thread. The test-mode-enabled logic is only really useful in the main thread, but it's simpler to just do it in all threads. REVIEW: 118985 Diffs (updated) ----- autotests/kconfigtest.cpp a8482b7099df5921909830082d758dc3095e3241 src/core/ksharedconfig.cpp b7d155d5893502921d35d7dd971188b6a93a0620 Diff: https://git.reviewboard.kde.org/r/118985/diff/ Testing ------- no regression in "make test" in kconfig; still debugging races in helgrind threadtest (in kio). Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
