----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119038/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kcmutils Description ------- Previously we would crash with an assertion inside libdbus-1 because of additional / characters in the dbus path if X-KDE-Library in the .desktop file pointed to a plugin inside a subdirectory of the plugin path. We now just use the name of the library and strip all leading directories from the name that is registered in DBus This would allow moving all kcms into e.g. plugins/kcm5 which would allow cleaning up the plugins/ directory Diffs ----- src/kcmoduleproxy.cpp 7596f36e1e26ce080634f3cc0f89e27280423f25 Diff: https://git.reviewboard.kde.org/r/119038/diff/ Testing ------- - moved $KF5/lib64/plugins/kcm_clock.so to $KF5/lib64/plugins/kcm5/kcm_clock.so - changed X-KDE-Library to "kcm5/kcm_clock" in $KF5/share/kservice5/clock.desktop - ran kbuildsycoca5 "kcmshell5 clock" before this patch -> crash "kcmshell5 clock" after this patch -> works as expected Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
