-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119076/#review61422
-----------------------------------------------------------
The apidoc says:
* @param path_store If not null, the path of the icon is stored here,
* if the icon was found. If the icon was not found @p path_store
* is unaltered even if the "unknown" pixmap was returned.
- Christoph Feck
On July 1, 2014, 6:57 p.m., David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119076/
> -----------------------------------------------------------
>
> (Updated July 1, 2014, 6:57 p.m.)
>
>
> Review request for KDE Frameworks and Christoph Feck.
>
>
> Repository: kiconthemes
>
>
> Description
> -------
>
> KIconLoader: start by clearing the output variable
>
> in case people only check that and not the returned QIcon.
>
>
> Diffs
> -----
>
> src/kiconloader.cpp 4080a1d295ed442bbcc055b6274d98acdfb8fa4c
>
> Diff: https://git.reviewboard.kde.org/r/119076/diff/
>
>
> Testing
> -------
>
> unittests still pass.
>
> This is mostly for the testcase at https://git.reviewboard.kde.org/r/119058
> to make sense.
>
>
> Thanks,
>
> David Faure
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
