----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119152/#review61876 -----------------------------------------------------------
Ah. QT_DISABLE_DEPRECATED_BEFORE defaults to QT_VERSION_CHECK(5, 0, 0) (qglobal.h). That means basic functions such as QString::fromAscii are disabled because they're marked as deprecated since 5.0. Question is: Do we really want to override the default value for QT_DISABLE_DEPRECATED_BEFORE? - Kevin Funk On July 6, 2014, 10:17 p.m., Kevin Funk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119152/ > ----------------------------------------------------------- > > (Updated July 6, 2014, 10:17 p.m.) > > > Review request for KDE Frameworks and Stephen Kelly. > > > Repository: kdelibs4support > > > Description > ------- > > Do not define QT_DISABLE_DEPRECATED_BEFORE > > When defining it in your own project, you'll get: > <command-line>:0:0: warning: > "QT_DISABLE_DEPRECATED_BEFORE" redefined [enabled by default] > > Is there any reason for it to be there? > > > Diffs > ----- > > cmake/modules/ECMQt4To5Porting.cmake > 4204fa541790aa38c74b9d6f0b2111af2157b2bc > > Diff: https://git.reviewboard.kde.org/r/119152/diff/ > > > Testing > ------- > > > Thanks, > > Kevin Funk > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
