----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 -----------------------------------------------------------
Ship it! I have been using this for 4.x and 5.x for a while without issues. Unit tests (no matter how little they are) also pass, so this should go in. IMO this should also be pushed for kdelibs, which is affected in the same manner. - Luca Beltrame On Lug. 17, 2014, 11:23 a.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119323/ > ----------------------------------------------------------- > > (Updated Lug. 17, 2014, 11:23 a.m.) > > > Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin > Bříza. > > > Repository: kauth > > > Description > ------- > > pid based auth is racy because of pid reuse, don't use it. > > > Diffs > ----- > > src/backends/polkit-1/Polkit1Backend.cpp 165f7bb > > Diff: https://git.reviewboard.kde.org/r/119323/diff/ > > > Testing > ------- > > it builds > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
