----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/ -----------------------------------------------------------
Review request for KDE Frameworks and Christoph Cullmann. Repository: ktexteditor Description ------- Add the commands 'reload-highlighting' and 'edit-highlighting' to the developer console. This is a KF5 port of a review request I posted some weeks ago (https://git.reviewboard.kde.org/r/118616/). The highlighting definition for the highlighting currently in use gets opened when entering the command 'edit-highlighting', and the complete set of highlighting definition gets reloaded on entering 'reload-highlighting' (takes a second or two on my machine). I thought about a simple caching mechanism based on the mtime of the highlighting definitions, too, but it seems they only get loaded in KateSyntaxDocument::setIdentifier where there is no access to the respective KateHighlighting instance. Caching would require some kind of rewriting that code, then. If you think it’s worth it I could give it a try. Diffs ----- src/utils/kateglobal.cpp 27128529dde920dad92cc06e11f8a687a8880599 src/CMakeLists.txt 0862cff2c2f60c0fc89a9f6a2b427425ac18349c src/syntax/katehighlight.h 22d75b9e344d20f9dcbe1e9b94aebe169394c2db src/syntax/katehighlight.cpp b82354e5c1f41e9a843f4478332fe62f7cad95ea src/syntax/katehighlightreload.h PRE-CREATION src/syntax/katehighlightreload.cpp PRE-CREATION src/syntax/katesyntaxmanager.h 568154154149e7c649ec2c023c7e43d44ad07ea4 src/syntax/katesyntaxmanager.cpp ebc86f3835c5bf41e01ed9d0bf7f1f2bde65ca46 Diff: https://git.reviewboard.kde.org/r/119377/diff/ Testing ------- Using the two new commands on my development machine yields the desired results. Thanks, Christoph Rüßler
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
