> On Čec. 21, 2014, 11:42 dop., David Edmundson wrote: > > kio_mtp.cpp, line 268 > > <https://git.reviewboard.kde.org/r/119382/diff/1/?file=291425#file291425line268> > > > > why would there be a trailing slash on a filename? I'm quite confused > > as to the stripping slashes all over here.
You are right, there shouldn't be a trailing slash. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119382/#review62770 ----------------------------------------------------------- On Čec. 21, 2014, 11:02 dop., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119382/ > ----------------------------------------------------------- > > (Updated Čec. 21, 2014, 11:02 dop.) > > > Review request for KDE Frameworks and Philipp Schmidt. > > > Repository: kio-mtp > > > Description > ------- > > I ported kio-mtp to KF5 including: > kDebug -> qCDebug > KUrl -> QUrl > > And it doesn't need Kdelibs4Support. > > Also one thing which should be probably considered is including kio-mtp in > kio-extras. > > > Diffs > ----- > > CMakeLists.txt cb27440 > devicecache.h 1fa3932 > devicecache.cpp 54ca56f > filecache.h 590e799 > filecache.cpp dfd4fe6 > kio_mtp.h b05f09b > kio_mtp.cpp 6e587fa > kio_mtp_helpers.h b66adbd > kio_mtp_helpers.cpp 0f9ddbc > > Diff: https://git.reviewboard.kde.org/r/119382/diff/ > > > Testing > ------- > > My phone is visible in Dolphin and I was able to finally copy my photos from > phone to my laptop. > > > Thanks, > > Jan Grulich > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
