> On July 22, 2014, 7:42 a.m., Laurent Montel wrote: > > templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 > > <https://git.reviewboard.kde.org/r/119388/diff/1/?file=291491#file291491line43> > > > > bool KAboutData::setupCommandLine(QCommandLineParser *parser) > > { > > if (!d->_shortDescription.isEmpty()) { > > parser->setApplicationDescription(d->_shortDescription); > > } > > > > return > > parser->addOption(QCommandLineOption(QStringLiteral("author"), > > QCoreApplication::translate("KAboutData CLI", "Show author information."))) > > && > > parser->addOption(QCommandLineOption(QStringLiteral("license"), > > QCoreApplication::translate("KAboutData CLI", "Show license > > information."))); > > } > > > > setupCommandLine doesn't add addHelpOption or addVersionOption. > > I tested and not added.
I don't understand what the issue is. setupCommandLine doesn't do it and so I have done it in the code here. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/#review62848 ----------------------------------------------------------- On July 21, 2014, 4:16 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119388/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 4:16 p.m.) > > > Review request for KDE Frameworks and Anne-Marie Mahfouf. > > > Repository: kapptemplate > > > Description > ------- > > Add KDE Frameworks 5 simple app > > > Diffs > ----- > > templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.ui PRE-CREATION > CMakeLists.txt 726f8ad0a651aed549c0eb9c4ab3890d609b9903 > templates/C++/CMakeLists.txt 668af487115f3a251979e3addec93c124ba81299 > templates/C++/kde-frameworks5-simple/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5-simple/Messages.sh PRE-CREATION > templates/C++/kde-frameworks5-simple/README PRE-CREATION > templates/C++/kde-frameworks5-simple/icons/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5-simple/icons/hi16-apps-%{APPNAMELC}.png > PRE-CREATION > templates/C++/kde-frameworks5-simple/icons/hi32-apps-%{APPNAMELC}.png > PRE-CREATION > templates/C++/kde-frameworks5-simple/icons/hi48-apps-%{APPNAMELC}.png > PRE-CREATION > templates/C++/kde-frameworks5-simple/kde-frameworks5-simple.kdevtemplate > PRE-CREATION > templates/C++/kde-frameworks5-simple/kde-frameworks5-simple.png > PRE-CREATION > templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.cpp PRE-CREATION > templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.desktop PRE-CREATION > templates/C++/kde-frameworks5-simple/src/%{APPNAMELC}.h PRE-CREATION > templates/C++/kde-frameworks5-simple/src/CMakeLists.txt PRE-CREATION > templates/C++/kde-frameworks5-simple/src/main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119388/diff/ > > > Testing > ------- > > use kapptemplate to make the app, compile install and run > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
