> On July 25, 2014, 8:13 a.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml, line 42 > > <https://git.reviewboard.kde.org/r/119455/diff/3/?file=292514#file292514line42> > > > > I was thinking this can become just > > > > property real minimumWidth: Layout.minimumWidth > > > > Also this is currently wrong; we're adding style.padding.left as the > > gap between icon + label, but the RowLayout spacing is units.smallSpacing, > > so they are different > > Marco Martin wrote: > yeah, i tried thatdoesn't seem to report correct values. > I think in order to do that i need to set a fixed Layout.minimumWidth to > the label, but would be a quite arbitrary value, like 10 msizes or so > > David Edmundson wrote: > it's currently label.implicitWidth, so we'd want to still use that > instead of something arbitrary? > > actually maybe that makes this: > property real minimumWidth: Layout.preferredWidth > > instead of what I said. > > Marco Martin wrote: > right now is the minimum between its implicit width and that 10 > characters arbitrary (rationale: not having buttons overkill large by default) > > instead, Layout.preferredWidth seems to be -1
but handling that is what line 116 is for Math.max(theme.mSize(theme.defaultFont).width*12, style.minimumWidth); - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119455/#review63110 ----------------------------------------------------------- On July 25, 2014, 9:41 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119455/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 9:41 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this makes Button inherit from the QtControl and annd an accompaining > plasma-looking theme > > now, the ugly part of the patch: > iconSource is an url, so it screws up passing freedesktop compatible names > (it expects names of pngs local to the qml file directory, testimony of the > main platform target for controls actually being android/ios). one solution > may be overriding iconSource as a normal string, but i would like the theme > working also on a plain Button, so it extract only the filename from the url. > > > Diffs > ----- > > examples/applets/widgetgallery/contents/ui/Buttons.qml 9134df9 > src/declarativeimports/core/iconitem.cpp 38012cc > src/declarativeimports/plasmacomponents/qml/Button.qml 262e20f > src/declarativeimports/plasmacomponents/qml/styles/ButtonStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119455/diff/ > > > Testing > ------- > > in both a normal plasma session or the widget gallery buttons work fine, > painting is 100% identical > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
