> On July 29, 2014, 11:54 a.m., José Manuel Santamaría Lema wrote:
> > With the patch as is it doesn't build for me with Qt 5 but I could fix it
> > changing this couple of things in the resulting CMakeLists.txt after
> > applying the current patch:
> > - removing the use of macro_optional_add_subdirectory (and using
> > add_subdirectory instead)
> > - placing this line
> > set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH} ${ECM_KDE_MODULE_DIR})
> > right before this one
> > find_package(KF5 REQUIRED KDELibs4Support IconThemes)
Makes sense. Martin, how come did macro_optional_add_subdirectory work for you?
- Aleix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118263/#review63425
-----------------------------------------------------------
On July 3, 2014, 8:48 a.m., Martin Bříza wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118263/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 8:48 a.m.)
>
>
> Review request for KDE Frameworks and Polkit KDE Agent.
>
>
> Repository: polkit-kde-agent-1
>
>
> Description
> -------
>
> Use -DUSE_QT4=true to build against kdelibs4; -DUSE_QT5=true to build against
> KF5. Don't use anything to let cmake decide, with KF5 being a priority.
>
> Sorry for using KDELibs4Support - I tried to not do it but it required 8
> frameworks and a massive rewrite.
>
>
> Diffs
> -----
>
> AuthDialog.h 620145d
> AuthDialog.cpp f2c4886
> CMakeLists.txt f79b88f
> main.cpp 33ef236
> policykitlistener.cpp 6da9461
> polkit-kde-authentication-agent-1.desktop.in aa088cc
>
> Diff: https://git.reviewboard.kde.org/r/118263/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Martin Bříza
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
