> On Aug. 4, 2014, 1:13 a.m., Lukáš Tinkl wrote: > > No change here, ie. it doesn't restore the file dialog geometry. > > Thomas Lübking wrote: > what is your precise testcase? > a bit remote because of your other patches: did you check that the > correct platformtheme lib is used? (ran into this in a custom installation. > self compiled plugin ended up in a different path than the distro qt5 plugin > path) > is the size data updated in kdeglobals? > > Lukáš Tinkl wrote: > Testcase: opening a filedialog in any Qt/KDE app, restarting the app -> > default file/window size > > I guess I'm using the correct platformtheme, otherwise I wouldn't be > seeing KDE fialogs right? Also, toplevel windows are not restored either > > Yup, the size is always correctly saved to the config files
I can also confirm that file dialogs do not have their size restored with this patch (using tests/qfiledialogtest and also real dialogs around the workspace), however testing the dir selection does give me properly restored size dialog (./qfiledialogtest --staticFunction getExistingDirectory --modal on). Qt 5.3.1 here. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/#review63726 ----------------------------------------------------------- On Aug. 3, 2014, 9:16 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119594/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2014, 9:16 p.m.) > > > Review request for KDE Frameworks, kdelibs, Aleix Pol Gonzalez, Lukáš Tinkl, > and Martin Klapetek. > > > Repository: frameworkintegration > > > Description > ------- > > summarized > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 520b6f5 > > Diff: https://git.reviewboard.kde.org/r/119594/diff/ > > > Testing > ------- > > See > https://git.reviewboard.kde.org/r/119512/ > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
