----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119698/#review64263 -----------------------------------------------------------
Ship it! Makes sense to me. - Aleix Pol Gonzalez On Aug. 11, 2014, 12:40 p.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119698/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 12:40 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > ------- > > We are suggesting people to port from deprecated KButtonGroup to QGroupBox > but the dialog manager does not behave the same. This patch fixes it by > assuming that in a groupbox that is composed exclusively by radio buttons and > whose config item is an int to save the index of the checked radio button > instead of if the group box itself is checked. > > > Diffs > ----- > > src/kconfigdialogmanager.cpp 94d3cd1 > > Diff: https://git.reviewboard.kde.org/r/119698/diff/ > > > Testing > ------- > > KGeography frameworks with KButtonGroup ported to QGroupBox works. > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
