----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119711/#review64267 -----------------------------------------------------------
src/kdeinit/kinit.cpp <https://git.reviewboard.kde.org/r/119711/#comment44918> This can't work, it's replacing a full path with a relative path. The goal of this code was s/libexec/lib/ AFAICS, just like the next block does s/bin/lib/ (and then they append the filename). - David Faure On Aug. 11, 2014, 2:22 p.m., Nicolas Lécureuil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119711/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2014, 2:22 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kinit > > > Description > ------- > > Resolves the problem of passing relative vs. absolute > KF5_LIBEXEC_INSTALL_DIR/LIBEXEC_INSTALL_DIR. > > > Diffs > ----- > > src/config-kdeinit.h.cmake 76cd867 > src/kdeinit/CMakeLists.txt 8a84774 > src/kdeinit/kinit.cpp 296ebfd > src/klauncher/CMakeLists.txt 8a251ff > src/klauncher/klauncher.cpp 124011e > src/start_kdeinit/CMakeLists.txt 56a91e3 > src/start_kdeinit/start_kdeinit.c 02d4d54 > src/start_kdeinit/start_kdeinit_wrapper.c f35c4a9 > > Diff: https://git.reviewboard.kde.org/r/119711/diff/ > > > Testing > ------- > > Before it searches for /usr//usr/libexec and after all is fine. > > > Thanks, > > Nicolas Lécureuil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
