----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119805/#review64653 -----------------------------------------------------------
Great work! I've tested this patch in this configuration and it works: no PySVN, SVN installed, Python 2. I have one question, though: why do you try to get the temporary path for the cached file using three different OS-dependent methods while you have an OS-independent fallback? Why not directly use tempfile.gettempdir? - Denis Steckelmacher On Aug. 16, 2014, 3:29 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119805/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2014, 3:29 p.m.) > > > Review request for KDE Frameworks, Denis Steckelmacher and Aurélien Gâteau. > > > Repository: kapidox > > > Description > ------- > > WebSVN is not set up to deal with a large number of hits - it is > intended for casual browsing. "svn export" is much more efficient, and > the anonsvn servers are meant to take this load. > > Given that we would like developers to be generating documentation to > check their doxygen markup, we should use a method that scales. > > This uses "svn export" (either through libsvn python bindings or the > command-line utility) if it can. It also caches the result for an hour > (since the accounts file is only updated server-side once an hour > anyway). > > > Diffs > ----- > > src/kapidox/generator.py ba4fad92d4b027d791107c58b15b26187d6f3087 > > Diff: https://git.reviewboard.kde.org/r/119805/diff/ > > > Testing > ------- > > Extracted download_kde_identities() function (and its dependent functions) to > another script, and tested with python2 (with libsvn bindings), python3 > (without) and python3 (with the svn command line altered so that it would > fall back to websvn) - both with and without a cache file/cache directory > present. > > Also ran kgenframeworksapidox (python2), and checked that David Faure was > correctly listed as the maintainer of KArchive, with an email address. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
