----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65826 -----------------------------------------------------------
Looks like good idea. - Christoph Cullmann On Sept. 5, 2014, 8:39 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120062/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2014, 8:39 a.m.) > > > Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, > Friedrich W. H. Kossebau, and Laurent Montel. > > > Repository: kxmlgui > > > Description > ------- > > This simplifies app development, which otherwise needs to write everything > twice, like this: > m_actFullScreen->setShortcut(Qt::Key_F11) > collection->setDefaultShortcut(m_actFullScreen, Qt::Key_F11); > > > Diffs > ----- > > autotests/kactioncollectiontest.cpp > 9047b32b3909371b42a9b26c79c5a58376a84783 > src/kactioncollection.h 5dbc3c2ddd8f93af9874454d735ad2a237bf4afa > src/kactioncollection.cpp 6c7af0ffeb7e874ea0bce8096abde5c7df41f2e5 > > Diff: https://git.reviewboard.kde.org/r/120062/diff/ > > > Testing > ------- > > kactioncollectiontest now skips calling setShortcut if it's the same as the > default, and still passes. > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
