----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/#review65948 -----------------------------------------------------------
Ship it! Yes, this is indeed the best solution. Let people use the QGuiApplication method instead, that's the Qt way, and in the rare case we need the icon name, we can use QIcon::name(). (could be empty, of course, but in KDE apps it won't be, we load our icons from the icon theme). - David Faure On Aug. 28, 2014, 4:39 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119977/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 4:39 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcoreaddons > > > Description > ------- > > Mark setProgramIconName() as deprecated, it did not do anything since > kcoreaddons no longer uses QtGui so it can not set the icon. > > BUG: 337938 > > > Diffs > ----- > > src/lib/kaboutdata.h 2d8bd5645150a57739e94f9f71b112b20ec0e01f > src/lib/kaboutdata.cpp 5ad81de814c123f50b17bb542331459e15649f4b > > Diff: https://git.reviewboard.kde.org/r/119977/diff/ > > > Testing > ------- > > compiled a program made with kapptemplate 4.14.1 which uses this function, > successfully gives a warning during compile > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
