----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120093/#review66015 -----------------------------------------------------------
Ship it! Ideally this should use qCDebug though (with a call to setFilterRules <category>.debug=false). - David Faure On Sept. 7, 2014, 1:29 p.m., Christoph Cullmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120093/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2014, 1:29 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcoreaddons > > > Description > ------- > > Guard the 'KDirWatchPrivate::addEntry: Added File...' with same guard as the > removeEntry output. > Guard available methods with same trick, will allow use in non-debug build of > that output. > > > Diffs > ----- > > src/lib/io/kdirwatch.cpp 7abb32a > > Diff: https://git.reviewboard.kde.org/r/120093/diff/ > > > Testing > ------- > > Tested with Kate, removed the super verbose "Added File..." output for any > opened file. > Available methods are gone in output, too. > > > Thanks, > > Christoph Cullmann > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel