----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138/#review66289 -----------------------------------------------------------
autotests/kurifiltertest.cpp <https://git.reviewboard.kde.org/r/120138/#comment46272> Unbalanced spaces, add space after '(' to match current coding style. I should run astyle-kdelibs over the whole thing though. Can you add tests for "///" and "//foo" (should turn into smb://foo iirc)? src/urifilters/shorturi/kshorturifilter.cpp <https://git.reviewboard.kde.org/r/120138/#comment46271> This looks slow. It will go through a very long path, counting the number of slashes, even though it could stop at the first non-'/' character and give up. Doing it fast requires a small while loop. - David Faure On Sept. 11, 2014, 8:50 a.m., Arjun Ak wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120138/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2014, 8:50 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > "///..." should produce `QUrl("file:///")` not `QUrl("file://")` > > > Diffs > ----- > > autotests/kurifiltertest.cpp b84dcd0 > src/urifilters/shorturi/kshorturifilter.cpp 00668d9 > > Diff: https://git.reviewboard.kde.org/r/120138/diff/ > > > Testing > ------- > > > Thanks, > > Arjun Ak > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
