> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > I've added some comments inline. You should wait for David's feedback > > though. > > > > BTW, do other platforms, which support ".hidden" files already, only > > support full file names in that file, or can you add wildcards (such as > > "*~", "*.log", etc.) as well?
I've tested Nautilus and Thunar (which support ".hidden"), and it looks like wildcards are not supported there. Only full names work. And leading and trailing slashes are not ignored (which makes sense, because files may actually have leading/trailing spaces). This patch has the same behavior. It would be a nice feature for all file managers, but it would mean more overhead. > On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.h, line 420 > > <https://git.reviewboard.kde.org/r/119607/diff/2/?file=301214#file301214line420> > > > > I think that you should not make this part of the public API. AFAICS, > > you're not using it anywhere outside KCoreDirLister, right? I left this method (and others) public because I thought that, maybe in the future, someone may want to use this method. But you're right, it's not used anywhere else and should probably be private/protected. > On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 2801 > > <https://git.reviewboard.kde.org/r/119607/diff/2/?file=301215#file301215line2801> > > > > I think that you can remove this line. Oops, forgot to remove `QString` from line `QString name = stream.readLine();` below! - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review66475 ----------------------------------------------------------- On Set. 14, 2014, 3:32 p.m., Bruno Nova wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119607/ > ----------------------------------------------------------- > > (Updated Set. 14, 2014, 3:32 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Bugs: 64740 and 246260 > https://bugs.kde.org/show_bug.cgi?id=64740 > https://bugs.kde.org/show_bug.cgi?id=246260 > > > Repository: kio > > > Description > ------- > > This adds support for *.hidden* files to KDE. > > When listing a directory, the files/folders listed in the *.hidden* file will > be hidden, unless the user has chosen to show hidden files. > > This patch was initially based on the patch provided by Mark in Bug #246260. > > > Diffs > ----- > > src/core/kcoredirlister.h e6ba2ac > src/core/kcoredirlister.cpp a31d629 > src/core/kfileitem.h bebc241 > src/core/kfileitem.cpp 74dc069 > > Diff: https://git.reviewboard.kde.org/r/119607/diff/ > > > Testing > ------- > > Built and tested the patch in Project Neon. > Dolphin was still using KDE4/Qt4 version of the library, so I only tested > using the desktop folder widget, and "folder desktop". > It worked correctly when I pointed it to "~" and "~/Desktop" (I added > ".hidden" there). > However, it didn't work when I pointed it to the "Desktop folder" (the > default option, not the custom location "~/Desktop"). > More testing is required. > > The version for KDE4/Qt4 submitted to Bug #246260 was tested in Kubuntu > 14.04, and it worked everywhere I tested (Dolphin, open/save dialogs, folder > widget and detailed/tree view in Dolphin). > It wasn't an intensive test, though. > > > Thanks, > > Bruno Nova > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
