----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120535/ -----------------------------------------------------------
(Updated Oct. 9, 2014, 12:02 p.m.) Review request for KDE Frameworks and Frederik Gladhorn. Changes ------- Duplicated methods to be const rather than changing existing methods. Can someone confirm this is a binary compatible change? Repository: attica Description ------- Add const to getter methods. Diffs (updated) ----- src/downloaddescription.h 08796c9283d1412386f6e096b981c3afa2b1f55e src/downloaddescription.cpp f76a1601a53e66b836623f4ac7a67ceeb543c1f0 Diff: https://git.reviewboard.kde.org/r/120535/diff/ Testing ------- This builds and an improved knewstuff (with const AtticaDescription &foo, bar) in foreach lines builds. My only question about committing this is if it's allowed since it's a binary incompatible change. If it's not allowed I will add duplicates of these methods that are const and deprecate these non-const ones instead. Thanks, Jeremy Whiting
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel