> On Oct. 16, 2014, 6:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem)
Any more comments? Is this a SHIP IT? BTW: The same applies to SC 4, should I backport it to 4.14? - Stefan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/#review68567 ----------------------------------------------------------- On Oct. 16, 2014, 3:32 p.m., Stefan Brüns wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120605/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2014, 3:32 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 339193 > https://bugs.kde.org/show_bug.cgi?id=339193 > > > Repository: kio > > > Description > ------- > > The locked overlay should be added also for directories, as there is no > distinct "unreadable directory" icon. > No overlay icon for "gzip files with .gz file ending", there is a > mimetype icon for gzip files. > > BUGS: 339193 > > Signed-off-by: Stefan Brüns <stefan.bru...@rwth-aachen.de> > > > Diffs > ----- > > src/core/kfileitem.cpp 74dc069dc964f4fb0040a3dab916ff0d1e26602c > > Diff: https://git.reviewboard.kde.org/r/120605/diff/ > > > Testing > ------- > > Patched kio, see BR for new screenshot > > > Thanks, > > Stefan Brüns > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel