----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review68987 -----------------------------------------------------------
src/widgets/executablefileopendialog.h <https://git.reviewboard.kde.org/r/120666/#comment48253> m_ src/widgets/krun.cpp <https://git.reviewboard.kde.org/r/120666/#comment48252> Lambda expression maybe? connect(dialog, &ExecutableFileOpenDialog::finished, [this, dialog](int result) { ... } Avoids the cast hack and the need of a member variable. - Emmanuel Pescosta On Oct. 22, 2014, 6:10 p.m., Arjun AK wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120666/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2014, 6:10 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This patch makes KIO show a dialog box asking the user what to do (either > open it using a text editor or execute it) when he clicks on a script or a > desktop file. > > See also: https://git.reviewboard.kde.org/r/120171/ > > > Diffs > ----- > > src/widgets/CMakeLists.txt 4060cdf > src/widgets/executablefileopendialog.h PRE-CREATION > src/widgets/executablefileopendialog.cpp PRE-CREATION > src/widgets/krun.cpp 6ac42da > src/widgets/krun_p.h 69e2e98 > > Diff: https://git.reviewboard.kde.org/r/120666/diff/ > > > Testing > ------- > > > Thanks, > > Arjun AK > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
