----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/#review70083 -----------------------------------------------------------
Code wise it's fine, same for the other two. It might be a good idea to wait for frameworks 5.6 otherwise we have a mixup between latest frameworks and latest plasma. I'm not sure about art side, in that forum thread Hugo says: >Personally, I do like icons on pushbuttons and the redundancy it bring Given he wrote most the Breeze style, frankly his opinion outranks everyone else combined. - David Edmundson On Nov. 6, 2014, 9:06 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121021/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 9:06 p.m.) > > > Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. > > > Repository: kdelibs4support > > > Description > ------- > > sumamrized, also see > https://forum.kde.org/viewtopic.php?f=285&t=123587 > https://git.reviewboard.kde.org/r/121019/ > https://git.reviewboard.kde.org/r/121020/ > > > Diffs > ----- > > src/kdeui/k4style.cpp a1a2ab1 > src/kdeui/kglobalsettings.h d63ac69 > > Diff: https://git.reviewboard.kde.org/r/121021/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
