> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What was the isseu on linux?
The `_p.h` files do not contain export macros. I showed you some of the build errors above. - Milian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 ----------------------------------------------------------- On Nov. 10, 2014, 1:50 p.m., Milian Wolff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121093/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 1:50 p.m.) > > > Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and > Jeremy Whiting. > > > Repository: knewstuff > > > Description > ------- > > This reverts commit 3ab92282a8909258dc6fa24a3b9d065ee49f8731. > > This fixes the compile/link errors of the unit tests: > > Linking CXX executable knewstuffentrytest > /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: > error: undefined reference to 'KNS3::EntryInternal::EntryInternal()' > /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:70: > error: undefined reference to 'KNS3::EntryInternal::setEntryXML(QDomElement > const&)' > /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:71: > error: undefined reference to 'KNS3::EntryInternal::toEntry() const' > /home/milian/projects/kf5/src/frameworks/knewstuff/autotests/knewstuffentrytest.cpp:69: > error: undefined reference to 'KNS3::EntryInternal::~EntryInternal()' > collect2: error: ld returned 1 exit status > > and similar. > > > Diffs > ----- > > autotests/CMakeLists.txt 267f9b1eec47c2cc67106e2ca95f78033f92c86b > > Diff: https://git.reviewboard.kde.org/r/121093/diff/ > > > Testing > ------- > > Compiles again and tests pass. Patrick, was this before an issue on Windows > or why did you push this change? See also > https://git.reviewboard.kde.org/r/120592/ > > > Thanks, > > Milian Wolff > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
