----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70214 -----------------------------------------------------------
lib/konq/src/konq_historyentry.h <https://git.reviewboard.kde.org/r/121080/#comment49091> Just wondering: the place I found in Qt which does something similar (dummy qHash for MSVC), doesn't have any ifdef: qitemselectionmodel.h. Any idea why we have one here? It seems to me that this is useful for both the lib and the app, since they both see the QList<KonqHistoryEntry> (whose toSet method requires a qHash implementation) lib/konq/src/konq_historyentry.h <https://git.reviewboard.kde.org/r/121080/#comment49092> const ref, no? - David Faure On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121080/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2014, 10:26 p.m.) > > > Review request for KDE Base Apps, KDE Frameworks and kdewin. > > > Repository: kde-baseapps > > > Description > ------- > > Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is > not available. Implement it instead. > > > Diffs > ----- > > lib/konq/src/konq_historyentry.h de34d6b > > Diff: https://git.reviewboard.kde.org/r/121080/diff/ > > > Testing > ------- > > It builds (MSVC2013 - 64bit) after this patch (along other patches I'm > sending to review today). Kdebase-apps is still not very functional, though > (missing icons and weird UI). > > > Thanks, > > Andrius da Costa Ribas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel