> On Lis. 12, 2014, 10:04 odp., Àlex Fiestas wrote: > > I would move this perhaps to plasma-workspace since this slave is really > > important for nowadays usage of the desktop (android phones etc). > > Aleix Pol Gonzalez wrote: > Well, there's important kio's as well in kio-extras. Question is, is it > useful outside the workspace? Would a cross-platform application use it? > > It seems to me they would, I can see amarok requiring it even on windows > or gnome.
To me it makes more sense to have it in kio-extras with the rest of kioslaves. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review70301 ----------------------------------------------------------- On Lis. 10, 2014, 9:30 dop., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121090/ > ----------------------------------------------------------- > > (Updated Lis. 10, 2014, 9:30 dop.) > > > Review request for KDE Frameworks, David Faure and Philipp Schmidt. > > > Repository: kio-extras > > > Description > ------- > > This patch moves kio-mtp from its frameworks branch to kio-extras. I believe > that this kioslave should be with the rest and not alone somewhere without > release. I also formatted it a bit to follow kdelibs coding style. > > Discussion about this move can be found here > http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2 > > > Diffs > ----- > > mtp/kio_mtp_helpers.h PRE-CREATION > mtp/kio_mtp_helpers.cpp PRE-CREATION > mtp/mtp-network.desktop PRE-CREATION > mtp/mtp.protocol PRE-CREATION > mtp/solid_mtp.desktop PRE-CREATION > mtp/filecache.cpp PRE-CREATION > mtp/kio-mtp.kdev4 PRE-CREATION > mtp/kio_mtp.h PRE-CREATION > mtp/kio_mtp.cpp PRE-CREATION > CMakeLists.txt 8f82688 > mtp/CMakeLists.txt PRE-CREATION > mtp/COPYING PRE-CREATION > mtp/LICENCE PRE-CREATION > mtp/Messages.sh PRE-CREATION > mtp/README PRE-CREATION > mtp/devicecache.h PRE-CREATION > mtp/devicecache.cpp PRE-CREATION > mtp/filecache.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121090/diff/ > > > Testing > ------- > > I have tested copying files, creating and removing folders in Dolphin with my > Nexus 4 and everything seems to work fine. > > > Thanks, > > Jan Grulich > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
