> On Nov. 13, 2014, 11:44 p.m., Albert Astals Cid wrote: > > +1 If you have to be blocking, use the proper blocking methods. Obviosuly > > it'd be better if no blocking call is used but since i know nothing about > > the code i'll just shut up now :D
We've been going through the code with david before, and there's some things we could do to make it more asynchronous. We agreed on having this as a first step. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70354 ----------------------------------------------------------- On Nov. 13, 2014, 6:24 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121113/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 6:24 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > We had a while loop which processed all application events whilst we > were in the middle of creating objects. This leads to weird bugs, and > workarounds in ShellCorona. > > Qt's methods forceCompletion does not seem to have the same problems and > works just as well. > > > Diffs > ----- > > src/kdeclarative/qmlobject.cpp 029edaf > > Diff: https://git.reviewboard.kde.org/r/121113/diff/ > > > Testing > ------- > > Ran plasmashell with many panels filled with applets > > Added debug on void ShellCorona::createWaitingPanels() to make sure it was > never called with m_loading true. > > > Thanks, > > David Edmundson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
