----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/#review70384 -----------------------------------------------------------
src/platformtheme/kdeplatformfiledialoghelper.cpp <https://git.reviewboard.kde.org/r/121098/#comment49209> Looking at QDialog docs, it says "modal : bool This property holds whether show() should pop up the dialog as modal or modeless." So as the modal is being set here, shouldn't the "if (windowModality == Qt::NonModal) {" just be removed instead and always call show()? - Martin Klapetek On Nov. 10, 2014, 7:17 p.m., Jeremy Whiting wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121098/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 7:17 p.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Repository: frameworkintegration > > > Description > ------- > > Before David's astyle commit, the show method used to call m_dialog->exec > if the window flags weren't nonmodal (i.e. modal dialogs). This got removed > somehow. > BUG:334963 > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp > 44eca192946f0da2b357b33e93a57ef0de05135b > > Diff: https://git.reviewboard.kde.org/r/121098/diff/ > > > Testing > ------- > > fifteen puzzle config with patch from > https://git.reviewboard.kde.org/r/121097/ now shows the dialog and lets you > choose a file. > > > Thanks, > > Jeremy Whiting > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
