> On Nov. 17, 2014, 4:33 p.m., Jeremy Whiting wrote: > > I tested this here and FileDialog qml still hangs the ui with this patch. > > (though at least the dialog appears) > > Martin Klapetek wrote: > Yes, QML still hangs, not sure why though. Looking into it. > > Martin Klapetek wrote: > So I've spent a considerable amount of time on this but to no avail. I've > even rewritten significant portion of our file dialog to match the gtk2 > platform theme plugin one, but it still wouldn't work. > > I'm at a loss here, sorry... > > Albert Astals Cid wrote: > Then maybe use https://git.reviewboard.kde.org/r/121098/diff/# since > Jeremy says qml dialogs work there?
No I discarded that patch, that makes qml dialogs work, but also makes the dialog show up twice when used from QFileDialog::anystaticmethod as seen from the standarddialogs qt example app. - Jeremy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70564 ----------------------------------------------------------- On Nov. 17, 2014, 10:46 a.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121153/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2014, 10:46 a.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > Based on https://git.reviewboard.kde.org/r/121098/ and on the GTK2 platform > theme, which does the modal show() like this. > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 44eca19 > > Diff: https://git.reviewboard.kde.org/r/121153/diff/ > > > Testing > ------- > > All kinds of file dialogs from tests/qfiledialogtest work as expected > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
