----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121562/#review72131 -----------------------------------------------------------
+1 - David Edmundson On Dec. 16, 2014, 5:42 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121562/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2014, 5:42 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kitemmodels > > > Description > ------- > > since qtbase commit ebef2ad1360c80ad62de5f4a1c4e7e4051725c1c "Make the empty > Q_ASSERT still check its argument for validity" the build shall fail. > alternative is to guard the Q_ASSERT with QT_NO_DEBUG > > > Diffs > ----- > > src/kselectionproxymodel.cpp 6774b75 > > Diff: https://git.reviewboard.kde.org/r/121562/diff/ > > > Testing > ------- > > does what it advertises > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
