> On Dec. 18, 2014, 1:05 a.m., Aleix Pol Gonzalez wrote: > > I think it's a useful component that can end up being really useful > > elsewhere, therefore I think kdeclarative it's a good place to be. > > > > I'd say it would be better to have it in a separate qml module. IIRC, the > > idea of kquickcontrols was to provide components that extend QtQuick > > Controls, rather than such generic components (see the KeySequenceButton). > > In fact, I would expect that to use something like that, I'd have to > > "import org.kde.plotter" or "import QtQuick.Plotter" rather than something > > else that happens to provide a Plotter class. > > > > Also I miss some more development over it, to get started some unit tests > > would be perfect, or at least an example application we can look at to test > > small things or just learn how to use it. > > > > Last, have you looked at the plotting component developed for ktouch? Is it > > comparable in any way? I'd love to duplicate there. > > https://projects.kde.org/projects/kde/kdeedu/kqtquickcharts/repository > > > > Thanks!
Own import, i'm not sure i like that much having a ton of very small ones, we're already loading too many plugins :/ Kquickcharts, I didn't knew that thing existed, if somebody told me before, I would have done things differently, damn. Anyways, i see it's similar, but not the same. it's still a qquickpainteditem and doesn't seem to support stacked graphs/spline interpolation, so seems slightly different. Maybe this may stay as small thing (even just in extracomponents) and kquickcharts for applications, boh - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/#review72219 ----------------------------------------------------------- On Dec. 17, 2014, 4:20 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121581/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2014, 4:20 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > This is an alternative, mutually exclusive to > https://gerrit.vesnicky.cesnet.cz/r/#/c/244 > and dependent from > https://git.reviewboard.kde.org/r/121575/ > > since the plotter component doesn't depend from libplasma, it may be useful > to have it outside of libplasma, so any applciation that wants it may use it. > Any opinion whether this should go here or in libplasma is welcome. > > > Diffs > ----- > > CMakeLists.txt 233ccce > src/qmlcontrols/kquickcontrols/CMakeLists.txt eef0420 > src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.h PRE-CREATION > src/qmlcontrols/kquickcontrols/kquickcontrolsplugin.cpp PRE-CREATION > src/qmlcontrols/kquickcontrols/plotter.h PRE-CREATION > src/qmlcontrols/kquickcontrols/plotter.cpp PRE-CREATION > src/qmlcontrols/kquickcontrols/qmldir 31d8b14 > > Diff: https://git.reviewboard.kde.org/r/121581/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
