----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121862/#review73243 -----------------------------------------------------------
Ship it! Looks good to me, apart from these few things. src/runtime/CMakeLists.txt <https://git.reviewboard.kde.org/r/121862/#comment50941> Is this one really necessary? Casting QString to char* is EVIL. src/runtime/CMakeLists.txt <https://git.reviewboard.kde.org/r/121862/#comment50942> Hmm, this can be killed, no? :) QWS no longer exists. src/runtime/CMakeLists.txt <https://git.reviewboard.kde.org/r/121862/#comment50943> This should be KF5_INSTALL_TARGETS_DEFAULT_ARGS instead. - David Faure On Jan. 5, 2015, 3:22 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121862/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2015, 3:22 p.m.) > > > Review request for KDE Frameworks, David Faure, Martin Gräßlin, and Hrvoje > Senjan. > > > Repository: kglobalaccel > > > Description > ------- > > This is a review request for the final move, I intentionally left out all the > runtime/ files to not clutter this review (it's direct move from the > workspace) and posting only the buildsystem and related changes. > > The runtime daemon is now no longer a kdeinit executable, meaning the > circular dependency should be no more. > > Would be pretty awesome to get this into 5.6, so Plasma 5.2 can be shipped > without it's own daemon copy. > > > Diffs > ----- > > CMakeLists.txt 4077f69 > metainfo.yaml d02975f > src/CMakeLists.txt 03fcbb9 > src/runtime/CMakeLists.txt PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121862/diff/ > > > Testing > ------- > > kglobalaccel daemon works as expected > > > Thanks, > > Martin Klapetek > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
