----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121908/#review73453 -----------------------------------------------------------
Ship it! Thanks!! - David Faure On Jan. 8, 2015, 7:42 a.m., Matthew Dawson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121908/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 7:42 a.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > To execute the KdePlatformTheme and the KStyle unit tests, a local > kdeglobals test file is required inside the Qt test folders. If the Qt > test folders don't exist when the test executable starts, this copy will > silently fail, causing further failures. > > Now, attempt to pre-create this folder before the copy. Also abort > the test if the folder creation or the file copy fail, to help diagnose > this issue in the future. > > > Diffs > ----- > > autotests/kdeplatformtheme_unittest.cpp > cc17ef6e3f3c0db3c4597105b32320f0aeb52b0f > autotests/kstyle_unittest.cpp e0e0046100acc195b1a3c36bbbe67e5861d7b7ee > > Diff: https://git.reviewboard.kde.org/r/121908/diff/ > > > Testing > ------- > > Executing the test suite locally now succeeds. > > > Thanks, > > Matthew Dawson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
