----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121907/#review73461 -----------------------------------------------------------
src/platformtheme/khintssettings.h <https://git.reviewboard.kde.org/r/121907/#comment51137> Make this one const too? - Albert Astals Cid On gen. 8, 2015, 2:08 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121907/ > ----------------------------------------------------------- > > (Updated gen. 8, 2015, 2:08 a.m.) > > > Review request for KDE Frameworks. > > > Repository: frameworkintegration > > > Description > ------- > > Make sure the methods that access the hash are const. > This way we make sure we don't create weird new hash members and we don't > need to do a double look-up for the value. > > > Diffs > ----- > > src/platformtheme/khintssettings.h 1d9c1d2 > > Diff: https://git.reviewboard.kde.org/r/121907/diff/ > > > Testing > ------- > > Test still passes, if I don't remove teh ~/.qt-test as discussed in the > kde-frameworks list. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
