----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121922/#review73512 -----------------------------------------------------------
I'm not convinced. Can't you use .json directly like we did in KDevelop? This solved the issue for us. desktop2json is pretty brittle and should become deprecated, I think. If you want to continue down this route, please add unit tests. src/services/kplugininfo.cpp <https://git.reviewboard.kde.org/r/121922/#comment51157> ',' or ';'. but, shouldn't it be only one or the other? isn't the .desktop file specification telling you which one it is? or is this all KDE custom? In KDevelop at least, the format always was "foo, bar, ...". Note the extra whitespace, which you are not trimming. - Milian Wolff On Jan. 8, 2015, 3:34 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121922/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 3:34 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > if a property is defined as a StringList in a servicetype, return it as an > actual stringlist upon KPluginInfo::property() instead of a string (with > commas to separe the entries), having the same behavior of KService > > This is necessary to have the same behavior between the old > KServiceTypeTrader::query() > and > KPluginTrader::applyConstraints > > because without list properties, all queries with the "in" keyword wouldn't > work, such as > "org.kde.plasma.time in [X-Plasma-Provides]" > > > Diffs > ----- > > src/services/kplugininfo.cpp aa5d263 > > Diff: https://git.reviewboard.kde.org/r/121922/diff/ > > > Testing > ------- > > queries on list properties with "in" do work now > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
