----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121949/#review73607 -----------------------------------------------------------
Ahh I was thinking the same thing yesterday, good stuff :) +1 from me! - Martin Klapetek On Jan. 9, 2015, 4:41 p.m., Elias Probst wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121949/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 4:41 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kservice > > > Description > ------- > > Until now, there was no way to tell from the logged message where it was > originating from. > This change makes it easier to find the originating application. > > > Diffs > ----- > > src/services/kplugininfo.cpp aa5d26386eb17a7e552b29c8fa66667961d68b16 > > Diff: https://git.reviewboard.kde.org/r/121949/diff/ > > > Testing > ------- > > Getting now messages logged which look like this: > ``` > Constructing a KPluginInfo object from old style JSON. Please use > kcoreaddons_desktop_to_json() for "Kate Session Applet" instead of > kservice_desktop_to_json() in your CMake code. > Constructing a KPluginInfo object from old style JSON. Please use > kcoreaddons_desktop_to_json() for "DataEngine for Kimpanel" instead of > kservice_desktop_to_json() in your CMake code. > Constructing a KPluginInfo object from old style JSON. Please use > kcoreaddons_desktop_to_json() for "Konsole Profiles" instead of > kservice_desktop_to_json() in your CMake code. > ``` > > This makes it definitely far easier to update the affected applications. > > > Thanks, > > Elias Probst > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel