> On Jan. 10, 2015, 5:05 p.m., Albert Astals Cid wrote: > > src/ktoolbar.h, line 217 > > <https://git.reviewboard.kde.org/r/121952/diff/2/?file=339326#file339326line217> > > > > Hidable sounds weird. Anyhow it's KToolbar, so i think having toolBar > > there is extra, what about isHidable?
Isn't proper (US) spelling "hideable"? Or better, "canBeHidden" - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121952/#review73670 ----------------------------------------------------------- On Jan. 9, 2015, 5:27 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121952/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 5:27 p.m.) > > > Review request for KDE Frameworks. > > > Bugs: 326713 > https://bugs.kde.org/show_bug.cgi?id=326713 > > > Repository: kxmlgui > > > Description > ------- > > Adds a "noHide" attribute in the xml format and implements it in the toolbar > handler, so we don't get an action to hide some toolbars. > > See related bug for more information. Basically if the application doesnt' > have a menu, one can hide the toolbar and then it can't come back. > > > Diffs > ----- > > src/ktoggletoolbaraction.cpp 3539ff3 > src/ktoolbar.h 54cc1cd > src/ktoolbar.cpp f79a149 > src/ktoolbarhandler.cpp 83c77bd > src/kxmlgui.xsd bca02f1 > > Diff: https://git.reviewboard.kde.org/r/121952/diff/ > > > Testing > ------- > > Fixes the attached bug, tests still pass. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
