> On Jan. 16, 2015, 12:47 p.m., David Edmundson wrote: > > src/kwindowsystem_p.h, line 48 > > <https://git.reviewboard.kde.org/r/122086/diff/1/?file=342288#file342288line48> > > > > this is pure virtual and you haven't provided a win or mac > > implementation that will break the build?
no, there are no win or mac implementations yet :-( Nothing to break. > On Jan. 16, 2015, 12:47 p.m., David Edmundson wrote: > > src/kwindowsystem_x11.cpp, line 798 > > <https://git.reviewboard.kde.org/r/122086/diff/1/?file=342290#file342290line798> > > > > this className code is very different from the one in pixmap; > > > > either this won't work, or the one in pixmap can be simplified in the > > same way. (I suspect the latter) yes in deed, the other one can be simplified and I also intend to do that in another review request. - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122086/#review74132 ----------------------------------------------------------- On Jan. 16, 2015, 11:01 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122086/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2015, 11:01 a.m.) > > > Review request for KDE Frameworks and kwin. > > > Repository: kwindowsystem > > > Description > ------- > > ::icons tries to retrieve all available icon sizes and combine them > into a single QIcon. On the X11 platform this can significantly > reduce the time needed to fetch all available icons compared to the > already existing ::icon methods which return a QPixmap of a specific > size. > > The change includes a new test application "icontest" which shows all > available icons in all available sizes for a window id passed as > command line argument. > > CHANGELOG: New method QIcon KWindowSystem::icons(WId win, int flags) > > > Diffs > ----- > > src/kwindowsystem_p_x11.h 0d4b6ba551776d2fa08030f78226ecdb3c80c889 > src/kwindowsystem_x11.cpp bf958ae63b48424fc412405259f082b740928f9a > tests/CMakeLists.txt ce68cc505a69ea9a3cf645e9ae587bd89abe1648 > tests/icontest.cpp PRE-CREATION > src/kwindowsystem_p.h 1f01145b5c7efe925fcb8242f92af17b704e01c9 > src/kwindowsystem.h 322322f12dda7279567be8420533ed22cffffd52 > src/kwindowsystem.cpp 65d215b6dfbf4df22e871fd7187fface75abb61b > > Diff: https://git.reviewboard.kde.org/r/122086/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
