----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122178/#review74461 -----------------------------------------------------------
Another approach would be a base class for such daemons, with a virtual method for the module loading (since it's implemented a bit differently, to avoid sycoca in kiod). But the dbus messageFilter can only be a static function, which needs to call self()->loadModule(), so the singleton (pointer to that base class) would have to be in the library too .... I generally don't like such "forcing a design on you" library code. - David Faure On Jan. 21, 2015, 9:03 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122178/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:03 a.m.) > > > Review request for KDE Frameworks and Kevin Ottens. > > > Repository: kdbusaddons > > > Description > ------- > > This is what the DBus message filter uses in order to find out which > module is being called, in order to auto-load it. > > > Diffs > ----- > > src/kdedmodule.h 706529a1639b17118abfd80a02b310dd2acbc00d > src/kdedmodule.cpp 54611c52775803ac734b52a53d79d2c762315112 > > Diff: https://git.reviewboard.kde.org/r/122178/diff/ > > > Testing > ------- > > autoloading modules in kiod and kded works > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
