----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122608/#review76197 -----------------------------------------------------------
Oh, cool. I hope it does not cause a slowdown. Can someone verify if it fixes the KRatingWidget with Oxygen theme when the frameworksintegration plugin is used? See bug 339863. - Christoph Feck On Feb. 17, 2015, 2:51 p.m., Olivier Goffart wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122608/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 2:51 p.m.) > > > Review request for KDE Frameworks, David Faure and Kevin Ottens. > > > Repository: kiconthemes > > > Description > ------- > > Fix QIcon::fromTheme(xxx, someFallback) would not return the fallback > > because KIconEngine::availableSize always return something even if the icon > is not there > > BUG: 342906 > > > Diffs > ----- > > src/kiconengine.cpp 530403e > > Diff: https://git.reviewboard.kde.org/r/122608/diff/ > > > Testing > ------- > > > Thanks, > > Olivier Goffart > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel