----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122755/#review76769 -----------------------------------------------------------
Thanks for the test! :) Maybe you can add some negative test cases (like read-only files - have a look at pastetest.cpp) as well and check if KIO sets the correct error codes? That would be really awesome! (Another test case which can be added to this test is in https://bugs.kde.org/show_bug.cgi?id=340950) Please note that I'm not a KIO developer, so better wait for an ack from a KIO dev before you implement my suggestions. ;) autotests/deldirtest.h <https://git.reviewboard.kde.org/r/122755/#comment52841> Maybe name it DeleteJobTest instead of DelDirTest? (because deleting of files and folders gets tested, so DelDir isn't correct) autotests/deldirtest.h <https://git.reviewboard.kde.org/r/122755/#comment52844> can be a const method autotests/deldirtest.cpp <https://git.reviewboard.kde.org/r/122755/#comment52843> I would add a "number of files" parameter to createEmptyTestFiles instead of using a global definintion or constant. autotests/deldirtest.cpp <https://git.reviewboard.kde.org/r/122755/#comment52845> KJob::NoError instead of 0? - Emmanuel Pescosta On Feb. 28, 2015, 4:28 p.m., Martin Blumenstingl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122755/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2015, 4:28 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > This adds some automated testcases for KIO::del(). > > My own code was buggy but I didn't notice this until I wrote those tests. > Maybe you want to have them upstream to make sure noone breaks KIO::del. > > > Diffs > ----- > > autotests/CMakeLists.txt f613c1a > autotests/deldirtest.h PRE-CREATION > autotests/deldirtest.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/122755/diff/ > > > Testing > ------- > > Tests are passing > > > Thanks, > > Martin Blumenstingl > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
