----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893/#review77320 -----------------------------------------------------------
src/kicondialog.cpp <https://git.reviewboard.kde.org/r/122893/#comment53104> I do not understand the check for "spontaneous". Is there a case where showIcons does not need to be called when receiving a showEvent? If this is to avoid stealing the focus, it probably needs to be moved down to the setFocus call. - Christoph Feck On March 11, 2015, 10:56 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122893/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 10:56 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kiconthemes > > > Description > ------- > > Populate the dialog on showEvent, this way you can use the regular QDialog > show() and exec() methods and use, for instance, Qt::WindowModal rather than > having showDialog() or openDialog() mess with modality. showDialog() could > probably be deprecated then. > > I don't know whether this is binary compatible. "you can safely reimplement a > virtual function defined in one of the base classes only if it is safe that > the programs linked with the prior version call the implementation in the > base class rather than the derived one" > > > Diffs > ----- > > src/kicondialog.h ee4edca > src/kicondialog.cpp 7a6c1f1 > > Diff: https://git.reviewboard.kde.org/r/122893/diff/ > > > Testing > ------- > > Just calling show() on the KIconDialog works as expected, the icon button in > kfileproperties thingie dialog still works. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
