----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122918/#review77498 -----------------------------------------------------------
Without testing anything, I think that this will break QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator. - Frederik Gladhorn On March 12, 2015, 1:19 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122918/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 1:19 p.m.) > > > Review request for KDE Frameworks and Frederik Gladhorn. > > > Bugs: 345002 > https://bugs.kde.org/show_bug.cgi?id=345002 > > > Repository: frameworkintegration > > > Description > ------- > > Not sure it's the right approach, but right now, the FileDialog > QtQuickControls will be broken in the kde interqation if set as modal, see > https://bugs.kde.org/show_bug.cgi?id=345002 > > the commit 2ee76f0 makes show() not do anything in that case, and the > FileDialog QML bindings seems to assume to call only show() > > > Diffs > ----- > > src/platformtheme/kdeplatformfiledialoghelper.cpp 9ffb1d9 > > Diff: https://git.reviewboard.kde.org/r/122918/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
