-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122206/#review77603
-----------------------------------------------------------
I know this is merged already but this patch is being applied to every KDE
package and I want to keep the discussion in a single place.
We already have a toggle option in CMake that is "BUILD_TESTING". If Gentoo
wants to not build the tests (I'm not judging if they should, let them be free
to do it), they can just set BUILD_TESTING to OFF. I understand that CMake will
still try to find Qt5Test and fail, but here is where I think we got it wrong:
This patch does the following:
if (Qt5Test is not found)
BUILD_TESTING = OFF
What I think this patch should be doing is this:
if (BUILD_TESTING == OFF)
Don't look for Qt5Test
Did I miss something or this seems more reasonable to you guys as well?
- Albert Vaca Cintora
On Feb. 6, 2015, 4:14 p.m., Andreas Sturmlechner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122206/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2015, 4:14 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kio
>
>
> Description
> -------
>
> [kio] Make tests optional
> This is a small patch to CMakeLists.txt to only depend on Qt5Test if
> BUILD_TESTING.
>
>
> Diffs
> -----
>
> CMakeLists.txt c1ed03f6cac648517828aec60e896baf9fbcfd9d
>
> Diff: https://git.reviewboard.kde.org/r/122206/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andreas Sturmlechner
>
>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
